Messages in this thread | | | Date | Sat, 22 Dec 2007 23:56:57 -0600 | From | Eric Sandeen <> | Subject | Re: [PATCH] (UPDATED) ecryptfs: check for existing key_tfm at mount time |
| |
Andrew Morton wrote: > On Sat, 22 Dec 2007 11:42:37 -0600 Eric Sandeen <sandeen@redhat.com> wrote: > >> Andrew Morton wrote: >> >>> It would all look a lot more solid if this locking was retained and both >>> ecryptfs_tfm_exists() and ecryptfs_add_new_key_tfm() were designed to be >>> called under key_tfm_list_mutex. >> Hmm good point, sorry for missing that. How's this look? > > key_tfm_list_mutex gets used in fs/ecryptfs/main.c but it is static in > fs/ecryptfs/crypto.c >
Ah crud that was a bunk-ism in -mm that I missed.
I'll send another updated patch soon.
-Eric
| |