lkml.org 
[lkml]   [2007]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 35/50] KVM: MMU: Move dirty bit updates to a separate function
    Date
    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    drivers/kvm/paging_tmpl.h | 23 +++++++++++++++--------
    1 files changed, 15 insertions(+), 8 deletions(-)

    diff --git a/drivers/kvm/paging_tmpl.h b/drivers/kvm/paging_tmpl.h
    index 4538b15..a0f84a5 100644
    --- a/drivers/kvm/paging_tmpl.h
    +++ b/drivers/kvm/paging_tmpl.h
    @@ -69,6 +69,17 @@ struct guest_walker {
    u32 error_code;
    };

    +static void FNAME(update_dirty_bit)(struct kvm_vcpu *vcpu,
    + int write_fault,
    + pt_element_t *ptep,
    + gfn_t table_gfn)
    +{
    + if (write_fault && !is_dirty_pte(*ptep)) {
    + mark_page_dirty(vcpu->kvm, table_gfn);
    + *ptep |= PT_DIRTY_MASK;
    + }
    +}
    +
    /*
    * Fetch a guest pte for a guest virtual address
    */
    @@ -144,10 +155,8 @@ static int FNAME(walk_addr)(struct guest_walker *walker,
    if (walker->level == PT_PAGE_TABLE_LEVEL) {
    walker->gfn = (*ptep & PT_BASE_ADDR_MASK)
    >> PAGE_SHIFT;
    - if (write_fault && !is_dirty_pte(*ptep)) {
    - mark_page_dirty(vcpu->kvm, table_gfn);
    - *ptep |= PT_DIRTY_MASK;
    - }
    + FNAME(update_dirty_bit)(vcpu, write_fault, ptep,
    + table_gfn);
    break;
    }

    @@ -157,10 +166,8 @@ static int FNAME(walk_addr)(struct guest_walker *walker,
    walker->gfn = (*ptep & PT_DIR_BASE_ADDR_MASK)
    >> PAGE_SHIFT;
    walker->gfn += PT_INDEX(addr, PT_PAGE_TABLE_LEVEL);
    - if (write_fault && !is_dirty_pte(*ptep)) {
    - mark_page_dirty(vcpu->kvm, table_gfn);
    - *ptep |= PT_DIRTY_MASK;
    - }
    + FNAME(update_dirty_bit)(vcpu, write_fault, ptep,
    + table_gfn);
    break;
    }

    --
    1.5.3.7


    \
     
     \ /
      Last update: 2007-12-23 16:07    [W:0.025 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site