Messages in this thread | | | Date | Sat, 22 Dec 2007 15:31:28 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH 1/3] Remove unused dependency |
| |
On Sat, Dec 22, 2007 at 12:50:12AM -0800, Joe Perches wrote: > On Sat, 2007-12-22 at 09:33 +0100, Sam Ravnborg wrote: > > arch/alpha/boot/mixc.c have: > > #include "../../../lib/inflate.c" > > Right. thanks. Sorry for the noise.
It was the removal of the file I objected against - not thremoval of the dependency. kbuild will find the dpendency as expressed in the Makefile all by itself.
> > Should the makefiles for the sources that include lib/inflate.c > have a dependency similar to arm and alpha? > > With: > arch/alpha/boot/misc.c > arch/arm/boot/compressed/misc.c > > Without: > arch/cris/arch-v10/boot/compressed/misc.c > arch/cris/arch-v32/boot/compressed/misc.c > arch/h8300/boot/compressed/misc.c > arch/m32r/boot/compressed/misc.c > arch/sh/boot/compressed/misc.c > arch/sh64/boot/compressed/misc.c > arch/x86/boot/compressed/misc_32.c > arch/x86/boot/compressed/misc_64.c > init/do_mounts_rd.c > init/initramfs.c > I looked at how inflate was used:
$ grep inflate */boot/Makefile alpha/boot/Makefile:$(obj)/misc.o: lib/inflate.c => redundandt dependency, can be deleted
powerpc/boot/Makefile:zlib := inffast.c inflate.c inftrees.c powerpc/boot/Makefile:zlibheader := inffast.h inffixed.h inflate.h inftrees.h infutil.h powerpc/boot/Makefile:$(addprefix $(obj)/,$(zlib)): $(obj)/%: $(srctree)/lib/zlib_inflate/% powerpc/boot/Makefile:$(addprefix $(obj)/,$(zlibheader)): $(obj)/%: $(srctree)/lib/zlib_inflate/% => I could not see why powerpc had to do so much special magic to get a working zlib - other archs has less troubles...
Did not llok at all archs but some other had funny stuff to use inflate and friends too. A cleanup of all this is needed.
Sam
| |