Messages in this thread |  | | | Date | Fri, 21 Dec 2007 07:47:55 +0000 | | From | "Jan Beulich" <> | | Subject | Re: [PATCH] constify tables in kernel/sysctl_check.c | |
>>> Eric W. Biederman <ebiederm@xmission.com> 21.12.07 00:05 >>>
>"Jan Beulich" <jbeulich@novell.com> writes:
>
>> Remains the question whether it is intended that many, perhaps even
>> large, tables are compiled in without ever having a chance to get used,
>> i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
>
>
>The constification looks good. The file should be compiled only when
>we have sysctl support. We use those tables when we call
>register_sysctl_table. Which we do a lot.
I understand this. Nevertheless, the tables take 23k on 64-bits, and many
of them are unused when certain subsystems aren't being built (and some
are even architecture specific). The arlan tables are a particularly good
example, but the netfilter ones are pretty big and probably not always
used, too.
Jan
|  |