Messages in this thread | | | Subject | Re: list corruption on ib_srp load in v2.6.24-rc5 | From | David Dillow <> | Date | Fri, 21 Dec 2007 17:18:52 -0500 |
| |
On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote: > I'm getting the following oops when doing the following commands: > > modprobe ib_srp > <add targets(s) to ib_srp using sysfs> > rmmod ib_srp > modprobe ib_srp > <OOPS> > > I'm going to try and track down how the list is getting corrupted; it > looks like attribute_container_list in > drivers/base/attribute_container.c is the one getting corrupted.
Ok, found the culprit, now to figure out the motive and fix it.
ib_srp's srp_cleanup_module calls srp_release_transport(), which calls transport_container_unregister() for the rport_attr_cont member of struct srp_internal.
That last unregister call is returning -EBUSY, but it gets ignored, and the list node gets erased (or just reused) when the module's text/memory is free'd.
Now, to see if ib_srp should be waiting for everything to be destroyed before calling srp_release_transport(), or if it is just not removing some attributes properly.
That's a next week thing if no one beats me to it.
| |