lkml.org 
[lkml]   [2007]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c
Thanks for catching this!

>>> Dave Jones <davej@redhat.com> 21.12.07 03:30 >>>
On Thu, Dec 20, 2007 at 04:14:05PM -0700, Eric W. Biederman wrote:

> Remains the question whether it is intended that many, perhaps even
> large, tables are compiled in without ever having a chance to get used,
> i.e. whether there shouldn't #ifdef CONFIG_xxx get added.

> -static struct trans_ctl_table trans_net_ax25_param_table[] = {
> +static const struct trans_ctl_table trans_net_ax25_table[] = {

we lost the _param, which will cause a duplicate definition with ..

> -static struct trans_ctl_table trans_net_ax25_table[] = {
> +static const struct trans_ctl_table trans_net_ax25_table[] = {

cut-n-paste thinko ?

Dave

--
http://www.codemonkey.org.uk



\
 
 \ /
  Last update: 2007-12-21 08:43    [W:0.034 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site