Messages in this thread | | | Date | Fri, 21 Dec 2007 07:41:23 +0000 | From | "Jan Beulich" <> | Subject | Re: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c |
| |
Thanks for catching this!
>>> Dave Jones <davej@redhat.com> 21.12.07 03:30 >>> On Thu, Dec 20, 2007 at 04:14:05PM -0700, Eric W. Biederman wrote:
> Remains the question whether it is intended that many, perhaps even > large, tables are compiled in without ever having a chance to get used, > i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
> -static struct trans_ctl_table trans_net_ax25_param_table[] = { > +static const struct trans_ctl_table trans_net_ax25_table[] = {
we lost the _param, which will cause a duplicate definition with ..
> -static struct trans_ctl_table trans_net_ax25_table[] = { > +static const struct trans_ctl_table trans_net_ax25_table[] = {
cut-n-paste thinko ?
Dave
-- http://www.codemonkey.org.uk
| |