lkml.org 
[lkml]   [2007]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] adt7470: Support per-sensor alarm files
Hi Darrick,

On Wed, 19 Dec 2007 14:11:25 -0800, Darrick J. Wong wrote:
> On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote:
> > In general we keep the all-in-one alarms file for compatibility, but
> > given that this driver is fairly new and libsensors never had specific
> > support for it anyway, it's probably OK to drop it this time.
>
> Thanks for the code review. I've made the changes you asked for and
> here's a new patch to supersede yesterday's.
> ---
> Remove the old alarms hack and replace it with per-sensor alarm files.
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>

Looks alright to me this time.

Acked-by: Jean Delvare <khali@linux-fr.org>

BTW, did you try your driver with lm-sensors 3.0.0?

Thanks,
--
Jean Delvare


\
 
 \ /
  Last update: 2007-12-20 11:01    [W:0.232 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site