Messages in this thread | | | Date | Thu, 20 Dec 2007 10:58:08 +0100 | From | Jean Delvare <> | Subject | Re: [PATCH] adt7470: Support per-sensor alarm files |
| |
Hi Darrick,
On Wed, 19 Dec 2007 14:11:25 -0800, Darrick J. Wong wrote: > On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote: > > In general we keep the all-in-one alarms file for compatibility, but > > given that this driver is fairly new and libsensors never had specific > > support for it anyway, it's probably OK to drop it this time. > > Thanks for the code review. I've made the changes you asked for and > here's a new patch to supersede yesterday's. > --- > Remove the old alarms hack and replace it with per-sensor alarm files. > > Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Looks alright to me this time.
Acked-by: Jean Delvare <khali@linux-fr.org>
BTW, did you try your driver with lm-sensors 3.0.0?
Thanks, -- Jean Delvare
| |