Messages in this thread | | | Date | Thu, 20 Dec 2007 21:07:41 +0000 | From | Alan Cox <> | Subject | Re: Trailing periods in kernel messages |
| |
> I missed the context on this one. So this is checking for periods at > the end of messages for printk's. We would need something a little > cleverer to ensure we are only checking the contents of the string. But > eminently doable. > > /me plays > > Ok, yes this seems ok. Have added it for 0.13.
Please remove it.
The kernel printk messages are sentences. English language sentences end with a full stop. They are messages printed up for normal human beings to read and they should therefore be properly written.
In fact you should warn if it ends with a newline without a full stop unless the next line is continuation of quoted text because that suggests a full stop has been missed out incorrectly.
Alan
| |