lkml.org 
[lkml]   [2007]   [Dec]   [20]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateThu, 20 Dec 2007 17:07:32 +0800
FromDave Young <>
Subject[PATCH -mm] kobject_add : kill unnecessary warning
Hi,
I don't know whether you or others have this change or not, if not please consider apply.

Kill the unnecessary warning in kobject_add if sysfs file EEXIST because of there's a similar one in sysfs_add_one

Signed-off-by: Dave Young <hidave.darkstar@gmail.com> 
---
kobject.c |   13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff -upr linux/lib/kobject.c linux.new/lib/kobject.c
--- linux/lib/kobject.c	2007-12-20 09:02:49.000000000 +0800
+++ linux.new/lib/kobject.c	2007-12-20 17:00:09.000000000 +0800
@@ -265,19 +265,10 @@ int kobject_add(struct kobject * kobj)
 
 	error = create_dir(kobj);
 	if (error) {
+		printk(KERN_ERR "kobject_add failed for %s (%d)\n",
+			       kobject_name(kobj), error);
 		/* unlink does the kobject_put() for us */
 		unlink(kobj);
-
-		/* be noisy on error issues */
-		if (error == -EEXIST)
-			printk(KERN_ERR "kobject_add failed for %s with "
-			       "-EEXIST, don't try to register things with "
-			       "the same name in the same directory.\n",
-			       kobject_name(kobj));
-		else
-			printk(KERN_ERR "kobject_add failed for %s (%d)\n",
-			       kobject_name(kobj), error);
-		dump_stack();
 	}
 
 	return error;

\
 
 \ /
  Last update: 2007-12-20 10:05    [from the cache]
©2003-2008