Messages in this thread | | | Date | Thu, 20 Dec 2007 08:58:53 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH 0/5] sg_ring for scsi |
| |
On Wed, Dec 19 2007, David Miller wrote: > From: Rusty Russell <rusty@rustcorp.com.au> > Date: Thu, 20 Dec 2007 18:53:48 +1100 > > > Manipulating the magic chains is horrible; it looks simple to the > > places which simply want to iterate through it, but it's awful for > > code which wants to create them. > > I'm not saying complexity is inherent in this stuff, but > assuming that it is the complexity should live as far away > from the minions (the iterators in this case). Therefore, > the creators is the right spot for the hard stuff.
Agree, and the missing bit is just moving the creators out of the driver parts and into a core helper. See the previous post on the 'sg' branch for 2.6.25.
-- Jens Axboe
| |