Messages in this thread | | | Date | Thu, 20 Dec 2007 08:28:47 -0800 | From | Mike Travis <> | Subject | Re: not needed patch |
| |
Ingo Molnar wrote: > * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote: > >> Ingo. >> >> commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9 is not needed. another >> patch (by you !! commit 699d934d5f958d7944d195c03c334f28cc0b3669 x86: >> fixup cpu_info array conversion) already removed clearing of >> c->cpu_index. in identify_cpu >> also it is not consisent to smpboot_32.c. (it will assign id to >> cpu_index right after >> >> *c = boot_cpu_data; >> ) > > well, it might in the worst-case be a superfluous change, but not cause > any problems in 2.6.24, right? > >> by revert commit fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, we could >> use c->cpu_index in identify_cpu. > > but that's 2.6.25 stuff, right? Travis? >
Looking at this more closely, yes my change is not needed and should be removed. I'm not sure what caused my cpu # to be all zeros when I was testing, but it now works ok without my change.
Thanks, Mike
| |