lkml.org 
[lkml]   [2007]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch 19/47] Optimize reference bit handling.
From: Martin Schwidefsky <schwidefsky@de.ibm.com>

page_referenced always tests and clears the reference bit in the
storage key, even if the page is not mapped. For a page that is
only accessed with sys_read this has a negative side effect.
A page that is only read once makes two trips over the inactive
list before it is removed from the page cache. When the page is
added to the page cache it is added to the start of the inactive
list. After it went through the inactive list the reference bit
is checked with a call to page_referenced which will find the
referenced bit in the storage key set because the copy_to_user
operation will set the bit. This causes the page to be added to
the start of the inactive list again. This wastes cpu cycles in
vmscan.

Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

mm/rmap.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Index: quilt-2.6/mm/rmap.c
===================================================================
--- quilt-2.6.orig/mm/rmap.c
+++ quilt-2.6/mm/rmap.c
@@ -391,9 +391,6 @@ int page_referenced(struct page *page, i
{
int referenced = 0;

- if (page_test_and_clear_young(page))
- referenced++;
-
if (TestClearPageReferenced(page))
referenced++;

@@ -409,6 +406,8 @@ int page_referenced(struct page *page, i
referenced += page_referenced_file(page);
unlock_page(page);
}
+ if (page_test_and_clear_young(page))
+ referenced++;
}
return referenced;
}
@@ -640,6 +639,8 @@ void page_remove_rmap(struct page *page,
* Leaving it set also helps swapoff to reinstate ptes
* faster for those pages still in swapcache.
*/
+ if (page_test_and_clear_young(page))
+ SetPageReferenced(page);
if (page_test_dirty(page)) {
page_clear_dirty(page);
set_page_dirty(page);
--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.



\
 
 \ /
  Last update: 2007-12-20 16:45    [W:0.206 / U:66.432 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site