lkml.org 
[lkml]   [2007]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] teach checkpatch.pl about list_for_each
    Em Sun, Dec 02, 2007 at 01:03:35PM +0100, Christer Weinigel escreveu:
    > Hi Andy,
    >
    > you seem to be the last person messing around with checkpatch.pl so I'm
    > addressing this to you. :-)
    >
    > checkpatch complains about the following:
    >
    > WARNING: no space between function name and open parenthesis '('
    > #520: FILE: drivers/spi/spi_s3c24xx_dma.c:478:
    > + list_for_each_entry (transfer, &message->transfers, transfer_list) {
    >
    > which I think is a bit bogus since it actually is a for statement in
    > disguise. The following patch adds list_for_each to the list of things
    > that look like functions that it shouldn't complain about.

    Then you would have to do this for tons other *_for_each*, such as
    hlist_for_each, etc, but:

    [acme@doppio net-2.6.25]$ find . -name "*.[ch]" | xargs grep
    '_for_each[a-z_]*(' | wc -l
    4370
    [acme@doppio net-2.6.25]$ find . -name "*.[ch]" | xargs grep
    '_for_each[a-z_]* (' | wc -l
    160
    [acme@doppio net-2.6.25]$

    I'd say that the common practice in the * _for_each_* use is to do just
    what checkpatch does right now, complain if the is a space. Ah, and that
    is also my personal preference 8-)

    - Arnaldo


    \
     
     \ /
      Last update: 2007-12-02 14:27    [W:0.022 / U:90.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site