lkml.org 
[lkml]   [2007]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/10] KVM: SVM: Fix FPU leak while emulating clts
    Date
    From: Amit Shah <amit.shah@qumranet.com>

    The clts code didn't use set_cr0 properly, so our lazy FPU
    processing wasn't being done by the clts instruction at all.

    (this isn't called on Intel as the hardware does the decode for us)

    Signed-off-by: Amit Shah <amit.shah@qumranet.com>
    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    drivers/kvm/kvm_main.c | 5 +----
    1 files changed, 1 insertions(+), 4 deletions(-)

    diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
    index b514dfb..504e81d 100644
    --- a/drivers/kvm/kvm_main.c
    +++ b/drivers/kvm/kvm_main.c
    @@ -1163,10 +1163,7 @@ int emulate_invlpg(struct kvm_vcpu *vcpu, gva_t address)

    int emulate_clts(struct kvm_vcpu *vcpu)
    {
    - unsigned long cr0;
    -
    - cr0 = vcpu->cr0 & ~CR0_TS_MASK;
    - kvm_arch_ops->set_cr0(vcpu, cr0);
    + kvm_arch_ops->set_cr0(vcpu, vcpu->cr0 & ~X86_CR0_TS);
    return X86EMUL_CONTINUE;
    }

    --
    1.5.3


    \
     
     \ /
      Last update: 2007-12-02 12:23    [W:0.039 / U:0.096 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site