Messages in this thread | | | From | Hans Verkuil <> | Subject | Re: [v4l-dvb-maintainer] [PATCH 2/2] ivtv: Remove a invalid shadow-variable | Date | Sun, 2 Dec 2007 20:43:26 +0100 |
| |
On Sunday 02 December 2007 18:47, Richard Knutsson wrote: > Remove the shadowing 'struct v4l2_chip_ident *chip', since it already > exists and makes the if-statement useless. > > Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Thanks,
Hans
> --- > Compile-tested on i386 with "allyesconfig" and "allmodconfig". > > > diff --git a/drivers/media/video/ivtv/ivtv-ioctl.c > b/drivers/media/video/ivtv/ivtv-ioctl.c index fd6826f..874aa22 100644 > --- a/drivers/media/video/ivtv/ivtv-ioctl.c > +++ b/drivers/media/video/ivtv/ivtv-ioctl.c > @@ -660,11 +660,8 @@ static int ivtv_debug_ioctls(struct file *filp, > unsigned int cmd, void *arg) chip->ident = V4L2_IDENT_NONE; > chip->revision = 0; > if (reg->match_type == V4L2_CHIP_MATCH_HOST) { > - if (v4l2_chip_match_host(reg->match_type, reg->match_chip)) { > - struct v4l2_chip_ident *chip = arg; > - > + if (v4l2_chip_match_host(reg->match_type, reg->match_chip)) > chip->ident = itv->has_cx23415 ? V4L2_IDENT_CX23415 : > V4L2_IDENT_CX23416; - } > return 0; > } > if (reg->match_type == V4L2_CHIP_MATCH_I2C_DRIVER) > > _______________________________________________ > v4l-dvb-maintainer mailing list > v4l-dvb-maintainer@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
| |