lkml.org 
[lkml]   [2007]   [Dec]   [19]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 19 Dec 2007 11:02:30 +0200 (EET)
FromPekka J Enberg <>
SubjectRe: [RFC/PATCH 2/8] revoke: inode revoke lock V7
Hi Jonathan,

(Thanks for the review!)

On Tue, 18 Dec 2007, Jonathan Corbet wrote:
> This is a relatively minor detail in the rather bigger context of this
> patch, but...> > > @@ -642,6 +644,7 @@ struct inode {> >  	struct list_head	inotify_watches; /* watches on this inode */
> >  	struct mutex		inotify_mutex;	/* protects the watches list */
> >  #endif
> > +	wait_queue_head_t	i_revoke_wait;> > That seems like a relatively hefty addition to every inode in the system
> when revoke - I think - will be a fairly rare operation.  Would there be
> any significant cost to using a single, global revoke-wait queue instead
> of growing the inode structure?

No, that's a good idea. I'll change it for the next patchset. Thanks!

                       Pekka


\
 
 \ /
  Last update: 2007-12-19 10:05    [from the cache]
©2003-2008