lkml.org 
[lkml]   [2007]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning
On Thu, 20 Dec 2007, David Chinner wrote:

> > I'm not sure I understand your namespace pollution issue, either.
>
> doing this globally:
>
> #ifdef CONFIG_SOMETHING
> extern int some_common_name(int a, int b, int c);
> #else
> #define some_common_name(a,b,c) 0
> #endif

I suspect it may be useful ensure all global identifiers for the key
subsystem are prefixed with key_, as 'copy_keys' does seem a little
generic.

> > +#ifdef CONFIG_SECURITY
> > +extern unsigned long mmap_min_addr;
> > +#endif
> > +
> > #include <asm/page.h>
> > #include <asm/pgtable.h>
> > #include <asm/processor.h>
>
> Fine by me.

I'll queue it for -mm & 2.6.25.


- James
--
James Morris
<jmorris@namei.org>


\
 
 \ /
  Last update: 2007-12-20 05:15    [W:0.087 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site