Messages in this thread | | | Date | Wed, 19 Dec 2007 16:45:55 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability |
| |
On Wed, 19 Dec 2007 16:41:25 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> It would be better to just add a stub implementation of > ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp > tricks.
And by this I really do mean going into each include/asm-*/pci.h and adding
struct pci_dev; (if needed) ...
static inline void ht_enable_msi_mapping(struct pci_dev *dev) { }
no macros, no ifdef tricks, no include tricks. Just straight, clean, fully typechecked C.
| |