lkml.org 
[lkml]   [2007]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] e1000: Use deferrable timer for watchdog
    Parag Warudkar wrote:
    > On 12/19/07, Kok, Auke <auke-jan.h.kok@intel.com> wrote:
    > [snip]
    >
    >> I can't possibly see any benefit from this other than that you just add up to a
    >> whole second to the initialization cycle, which is bad.
    >>
    > Well, Ok but it can't be bad - I've been using this patch sometime and
    > haven't seen any problem at all and powertop shows it reduces the
    > wakeups-from-idle.
    >
    > But whatever - no big deal since it already uses round_jiffies().

    why would this patch reduce wakeups even more than round_jiffies()? Does it make
    our ~2 second update interval not reliable? can you quantify "shows it reduces" ?
    Or timer only runs once every two seconds...

    maybe I just don't understand the effect of timer_set_deferrable() - we're already
    deferring it ourselves when we want to. If that is not working then I suggest that
    we fix that first instead of postponing the critical first run of the e1000
    watchdog task.

    People in the datacenter really don't want to see more delays when bringing up
    link, and we get frequent calls about it already being long on gigabit (not even
    minding spanning tree). Adding 25% to that time isn't going to down very nicely
    with them.


    \
     
     \ /
      Last update: 2007-12-19 22:41    [W:0.024 / U:65.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site