Messages in this thread | | | Subject | Re: [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces | From | Benjamin Herrenschmidt <> | Date | Tue, 18 Dec 2007 20:43:50 +1100 |
| |
On Tue, 2007-12-18 at 12:37 +0300, Ivan Kokshaysky wrote: > On Tue, Dec 18, 2007 at 11:02:37AM +1100, Benjamin Herrenschmidt wrote: > > +EXPORT_SYMBOL(pci_enable_device_io); > > +EXPORT_SYMBOL(pci_enable_device_mem); > > EXPORT_SYMBOL(pci_enable_device); > > Wouldn't it be better to export only the pci_enable_device_flags() > and make these three just "static inline" wrappers in pci.h?
Been thinking about it yeah. I don't want drivers to start using the _flags version directly tho, which is why I preferred going that way but if people prefer the inline version, I'll do that.
> > EXPORT_SYMBOL(pcim_enable_device); > > Looks like many SATA drivers would benefit from pcim_* equivalents > of pci_enable_device_{io,mem}, as they could happily work with just > a single MMIO BAR... Alan?
I have no experience with the pcim stuff, I would appreciate if somebody took care of that part.
Cheers, Ben.
| |