Messages in this thread |  | | | Date | Tue, 18 Dec 2007 12:37:15 +0300 | | From | Ivan Kokshaysky <> | | Subject | Re: [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces |
On Tue, Dec 18, 2007 at 11:02:37AM +1100, Benjamin Herrenschmidt wrote:
> +EXPORT_SYMBOL(pci_enable_device_io);
> +EXPORT_SYMBOL(pci_enable_device_mem);
> EXPORT_SYMBOL(pci_enable_device);
Wouldn't it be better to export only the pci_enable_device_flags()
and make these three just "static inline" wrappers in pci.h?
> EXPORT_SYMBOL(pcim_enable_device);
Looks like many SATA drivers would benefit from pcim_* equivalents
of pci_enable_device_{io,mem}, as they could happily work with just
a single MMIO BAR... Alan?
Ivan.
|  |