lkml.org 
[lkml]   [2007]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ps3: vuart: fix error path locking
On Wed, 12 Dec 2007 18:00:12 -0800
Geoff Levand <geoffrey.levand@am.sony.com> wrote:

> > This stray down would cause a permanent sleep which doesn't seem correct.
> > The other uses of this semaphore appear fairly mutex like it's even initialized
> > with init_MUTEX() .. So here a patch for removing this one down().
> >
> > Signed-off-by: Daniel Walker <dwalker@mvista.com>
> >
> > ---
> > drivers/ps3/ps3-vuart.c | 1 -
> > 1 file changed, 1 deletion(-)
>
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
>
>
> Looks, good.

Looks bad to me.

> Andrew, Please apply.

The current code:

if (result) {
dev_dbg(&dev->core, "%s:%d: drv->probe failed\n",
__func__, __LINE__);
down(&vuart_bus_priv.probe_mutex);
goto fail_probe;
}

up(&vuart_bus_priv.probe_mutex);

return result;

fail_probe:
ps3_vuart_set_interrupt_mask(dev, 0);
kfree(dev->driver_priv);
dev->driver_priv = NULL;
fail_dev_malloc:
vuart_bus_priv.devices[dev->port_number] = NULL;
fail_busy:
ps3_vuart_bus_interrupt_put();
fail_setup_interrupt:
up(&vuart_bus_priv.probe_mutex);
dev_dbg(&dev->core, "%s:%d: failed\n", __func__, __LINE__);
return result;
}

is correct. Although not exactly a thing of beauty.


\
 
 \ /
  Last update: 2007-12-19 02:19    [W:0.063 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site