[lkml]   [2007]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 09/28] FS-Cache: Release page->private after failed readahead [try #2]
    On Tuesday 18 December 2007 09:42, David Howells wrote:
    > Nick Piggin <> wrote:
    > > This is pretty nasty.
    > Why? If the fs doesn't set PG_private or PG_fscache on any pages before
    > calling read_cache_pages(), there's no difference.

    It is conceptually wrong.

    > Furthermore, the differences only crop up in the error handling paths.

    That doesn't make it any better.

    > > I would suggest either to have the function return the number of pages
    > > that were added to pagecache,
    > Which helps how?

    So the caller can do their own error handling / cleanup.

    > > or just open code it.
    > Well, I could give an alternative read_cache_pages(), I suppose, for just
    > this situation, but that means there are two parallel functions which then
    > both need to be maintained.

    I would be OK with that.

     \ /
      Last update: 2007-12-18 08:05    [W:0.022 / U:26.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site