Messages in this thread | | | Date | Tue, 18 Dec 2007 15:26:42 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH] ia64: Avoid unnecessary TLB flushes when allocating memory |
| |
On Tue, 18 Dec 2007 01:00:15 -0500 Kyle McMartin <kyle@mcmartin.ca> wrote:
> On Tue, Dec 18, 2007 at 10:05:45AM +0900, KAMEZAWA Hiroyuki wrote: > > On Thu, 13 Dec 2007 15:03:07 +0000 > > > > > + if (mm != active_mm) { > > > + /* Restore region IDs for mm */ > > > + if (mm && active_mm) { > > > + activate_context(mm); > > > + } else { > > > + flush_tlb_all(); > > > + return; > > > + } > > > } > > should be > > > > platform_global_tlb_purge is already (and afaict, only) called under > preempt_disable already. then again, the sn2 global_tlb_purge > does it, so possibly for completeness sake it should be added here as > well? > Thank you. I see. flush_tlb_range() is the only caller.
...maybe adding comment is helpful (for me :).
Thanks, -Kame
| |