Messages in this thread | | | Date | Mon, 17 Dec 2007 23:37:24 +0100 (CET) | From | Jan Engelhardt <> | Subject | Re: [PATCH net-2.6.25 1/8] Create ipv4_is_<type>(__be32 addr) functions |
| |
On Dec 13 2007 15:38, Joe Perches wrote: > >Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET >macros to inline functions ipv4_is_<type>(__be32 addr) > >Adds type safety and arguably some readability. > >Changes since last submission: > >Removed ipv4_addr_octets function >Used hex constants >Converted recently added rfc3330 macros > >Signed-off-by: Joe Perches <joe@perches.com> >--- >+static inline bool ipv4_is_loopback(__be32 addr) >+{ >+ return (addr & htonl(0xff000000)) == htonl(0x7f000000); >+} >+
Can we use __constant_htonl()?
>+static inline bool ipv4_is_private_10(__be32 addr) >+{ >+ return (addr & htonl(0xff000000)) == htonl(0x0a000000); >+}
What are these functions needed for, even? There does not seem to be any code (at least in davem's net-2.6.25:net/ipv4/, where I dared to grep) that uses them.
| |