lkml.org 
[lkml]   [2007]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

* Rene Herman <rene.herman@gmail.com> wrote:

>>> Signed-off-by: Rene Herman <rene.herman@gmail.com>
>>
>> hm, i see this as a step backwards from the pretty flexible patch
>> that David already tested. (and which also passed a few hundred
>> bootup tests on my x86 test-grid)
>
> Please see Alan's comment that udelay (and none) shouldn't yet be
> provided as a choice. It opens race windows in drivers even when it
> works in practice on most setups. The version with "udelay" and "none"
> is not minimal, not low risk and certainly not .24 material.

huh? By default we still use port 0x80. Any udelay is non-default and
needs the user to explicitly switch to it. But it enables us to debug
any suspected drivers by asking testers to: "please try this driver with
io_delay=udelay, does it still work fine?". So those extra options are
quite sensible. If you have any real technical arguments against that
then please let us know.

Ingo


\
 
 \ /
  Last update: 2007-12-17 23:01    [W:0.153 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site