lkml.org 
[lkml]   [2007]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)
    On Dec 17, 2007 10:10 AM, Eric Dumazet <dada1@cosmosbay.com> wrote:
    > On Mon, 17 Dec 2007 10:05:35 -0800
    > "Ray Lee" <ray-lk@madrabbit.org> wrote:
    >
    > > On Dec 17, 2007 9:55 AM, Eric Dumazet <dada1@cosmosbay.com> wrote:
    > > > - mid = (last - first) / 2 + first;
    > > > + while (low <= high) {
    > > > + mid = (low + high) / 2;
    > >
    > > I think you just introduced a bug. Think about what happens if
    > > low=high=MAX_LONG/2 + 1.
    > >
    >
    > Fortunatly this is not possible :)
    >
    > Hint : sizeof(struct exception_table_entry) is >= 8
    >
    > so high is garanteed to be <= MAX_LONG/8

    Ah, my bad. One of these days I'll learn to not post before coffee.


    \
     
     \ /
      Last update: 2007-12-17 19:15    [W:0.046 / U:29.788 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site