lkml.org 
[lkml]   [2007]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: INITIO scsi driver fails to work properly
On Mon, Dec 17 2007 at 18:20 +0200, Olivier Galibert <galibert@pobox.com> wrote:
> On Mon, Dec 17, 2007 at 06:08:59PM +0200, Boaz Harrosh wrote:
>> Below fixes a deadly typo. Might as well be included in 2.6.24
>
> You're sure ? scsi_for_each_sg includes a (sg)++ already...
>
>
>> scsi_for_each_sg(cmnd, sglist, cblk->sglen, i) {
>> sg->data = cpu_to_le32((u32)sg_dma_address(sglist));
>> total_len += sg->len = cpu_to_le32((u32)sg_dma_len(sglist));
>> + ++sg;
>> }
>
> OG.
> --
Don't mix up between the here sg that points to a driver specific struct sg_entry
and the here sglist which points to struct scatterlist, and is named sg inside
the scsi_for_each_sg() macro. Please inspect the full code, the patch does not
show the complete information. I admit it's confusing.

Boaz



\
 
 \ /
  Last update: 2007-12-17 18:05    [W:0.068 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site