lkml.org 
[lkml]   [2007]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86-64: make pda's cpunumber and nodenumber unsigned
>>> Ingo Molnar <mingo@elte.hu> 17.12.07 14:26 >>>
>
>* Jan Beulich <jbeulich@novell.com> wrote:
>
>> This generally allows better code to be generated, since the zero-
>> extension during 32-bit operations comes for free (needed when the
>> result is used as array index or similar), whereas sign extension must
>> be done explicitly and frequently requires a one byte larger
>> instruction due to the necessary rex64 prefix.
>
>good catch! Applied your patch to x86.git - queued it up for v2.6.25. I
>bet there are tons of other instances where we use signed instead of
>unsigned and get worse code generation.

Yes, definitely. This patch was kind of a testing one whether this is a
welcome change. As it appears to be, I'll probably produce more as I
run into respective cases.

Jan



\
 
 \ /
  Last update: 2007-12-17 14:39    [W:0.037 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site