lkml.org 
[lkml]   [2007]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/4] x86: fix asm memory constraints in local_64.h
    From
    Date
    Use the shorter +m form rather than =m and m.

    Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
    ---
    include/asm-x86/local_64.h | 30 ++++++++++++++----------------
    1 files changed, 14 insertions(+), 16 deletions(-)

    diff --git a/include/asm-x86/local_64.h b/include/asm-x86/local_64.h
    index da61076..7808f53 100644
    --- a/include/asm-x86/local_64.h
    +++ b/include/asm-x86/local_64.h
    @@ -5,32 +5,30 @@ static inline void local_inc(local_t *l)
    {
    __asm__ __volatile__(
    "incq %0"
    - :"=m" (l->a.counter)
    - :"m" (l->a.counter));
    + :"+m" (l->a.counter));
    }

    static inline void local_dec(local_t *l)
    {
    __asm__ __volatile__(
    "decq %0"
    - :"=m" (l->a.counter)
    - :"m" (l->a.counter));
    + :"+m" (l->a.counter));
    }

    static inline void local_add(long i, local_t *l)
    {
    __asm__ __volatile__(
    "addq %1,%0"
    - :"=m" (l->a.counter)
    - :"ir" (i), "m" (l->a.counter));
    + :"+m" (l->a.counter)
    + :"ir" (i));
    }

    static inline void local_sub(long i, local_t *l)
    {
    __asm__ __volatile__(
    "subq %1,%0"
    - :"=m" (l->a.counter)
    - :"ir" (i), "m" (l->a.counter));
    + :"+m" (l->a.counter)
    + :"ir" (i));
    }

    /**
    @@ -48,8 +46,8 @@ static inline int local_sub_and_test(long i, local_t *l)

    __asm__ __volatile__(
    "subq %2,%0; sete %1"
    - :"=m" (l->a.counter), "=qm" (c)
    - :"ir" (i), "m" (l->a.counter) : "memory");
    + :"+m" (l->a.counter), "=qm" (c)
    + :"ir" (i) : "memory");
    return c;
    }

    @@ -67,8 +65,8 @@ static inline int local_dec_and_test(local_t *l)

    __asm__ __volatile__(
    "decq %0; sete %1"
    - :"=m" (l->a.counter), "=qm" (c)
    - :"m" (l->a.counter) : "memory");
    + :"+m" (l->a.counter), "=qm" (c)
    + : : "memory");
    return c != 0;
    }

    @@ -86,8 +84,8 @@ static inline int local_inc_and_test(local_t *l)

    __asm__ __volatile__(
    "incq %0; sete %1"
    - :"=m" (l->a.counter), "=qm" (c)
    - :"m" (l->a.counter) : "memory");
    + :"+m" (l->a.counter), "=qm" (c)
    + : : "memory");
    return c != 0;
    }

    @@ -106,8 +104,8 @@ static inline int local_add_negative(long i, local_t *l)

    __asm__ __volatile__(
    "addq %2,%0; sets %1"
    - :"=m" (l->a.counter), "=qm" (c)
    - :"ir" (i), "m" (l->a.counter) : "memory");
    + :"+m" (l->a.counter), "=qm" (c)
    + :"ir" (i) : "memory");
    return c;
    }

    --
    1.5.4.rc0.1083.gf568



    \
     
     \ /
      Last update: 2007-12-17 01:57    [W:2.301 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site