Messages in this thread | | | Date | Sun, 16 Dec 2007 10:09:13 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast |
| |
On Sun, Dec 16, 2007 at 06:50:19PM +0900, Paul Mundt wrote: > > +static irqreturn_t gdrom_command_interrupt(int irq, void *dev_id) > > +{ > > + if (dev_id != &gd) > > + return IRQ_NONE; > > You aren't setting this up as a shared IRQ, so this shouldn't be > necessary.
It's not nessecary for shared irqs either. The irq code will never pass you a different cookied back than the one you passed in. Everything else would be a nighmare and these cargo cult workarounds wouldn't help either.
| |