Messages in this thread |  | | | Date | Sat, 15 Dec 2007 09:50:15 +0100 | | From | Ingo Molnar <> | | Subject | Re: FInal kprobes rollup patches | |
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Further unification work. There is a possible behavior change on
> X86_32 here.
>
> is_IF_modifier(p->opcode)
>
> to
>
> is_IF_modifier(p->ainsn.insn)
>
> Which should be equivalent, but is not purely cosmetic as the rest of
> the unification so far.
hm, could you split this into two, the pure-equivalence and the
possibly-modifying patch? (that way any potential breakage becomes
bisectable) Same end result, just two commits instead of one.
also, did you manage to run/test kprobes (on 32-bit or 64-bit x86), and
it worked fine?
Ingo
|  |