Messages in this thread |  | | | Subject | Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off | | From | Benjamin Herrenschmidt <> | | Date | Sat, 15 Dec 2007 17:22:50 +1100 |
| |
On Fri, 2007-12-14 at 12:02 -0600, Matt Mackall wrote: > > I added CONFIG_BUG, and I think the current behavior is correct. As > you've noticed, we have to evaluate condition, it may have > side-effects. And if code does: > > /* this indicates a driver bug, report and fail gracefully */ > if (WARN_ON(val == NULL)) > return -EFAULT; > > ..we surely want it to continue returning -EFAULT, regardless of > whether we log it, no? What use case did you have in mind?
I find such code totally distateful.
Ben.
|  |