lkml.org 
[lkml]   [2007]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] x86: clean up asm-x86/page*.h
>--- a/arch/x86/mm/fault_64.c
>+++ b/arch/x86/mm/fault_64.c
>@@ -158,22 +158,22 @@ void dump_pagetable(unsigned long addres
> pgd = __va((unsigned long)pgd & PHYSICAL_PAGE_MASK);
> pgd += pgd_index(address);
> if (bad_address(pgd)) goto bad;
>- printk("PGD %lx ", pgd_val(*pgd));
>+ printk("PGD %lx ", (unsigned long)pgd_val(*pgd));

Casts like this here and elsewhere look rather odd (in fact I think using
casts should really be limited to places where you either can't do it
differently or the code would become badly readable or much uglier
without them). I would therefore favor simply using the right formatting
specifier here.

Jan



\
 
 \ /
  Last update: 2007-12-14 09:33    [W:0.052 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site