lkml.org 
[lkml]   [2007]   [Dec]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    DateThu, 13 Dec 2007 23:25:06 -0800
    FromJeremy Fitzhardinge <>
    SubjectRe: Print taint info in more places.
    Dave Jones wrote:
    > On Fri, Dec 14, 2007 at 01:03:50AM +0100, Adrian Bunk wrote:
    >
    >  > >  #ifndef HAVE_ARCH_BUG
    >  > >  #define BUG() do { \
    >  > > -	printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __FUNCTION__); \
    >  > > +	printk(KERN_ERR "BUG: failure at %s:%d/%s()! (%s)\n",
    >  > > +		__FILE__, __LINE__, __FUNCTION__, print_tainted()); \
    >  > >  	panic("BUG!"); \
    >  > >  } while (0)
    >  > >  #endif
    >  > >...
    >  > 
    >  > Note that this only changes a handful of architectures and most likely 
    >  > not the ones you are interested in.
    >
    > Hmm, it appears that I was mistaken, and we never did patch x86.
    > Which leaves me wondering if its worth it or not to  patch BUG()
    > Anyways, here's the latest rev with the out-of-line changes as
    > suggested by Andi.
    >
    > init/main.c may not be the best place for the ool variant. suggestions?
    > 
    
    lib/bug.c would be the place for architectures using
    CONFIG_GENERIC_BUG.  x86 could be converted to use the BUG-trapping
    mechanism for WARN_ON like Power does, so it would be inherently out of
    line anyway.
    
        J
    
    
    
    \
     
     \ /
      Last update: 2007-12-14 08:27    [from the cache]
    ©2003-2008