lkml.org 
[lkml]   [2007]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Linux-fbdev-devel] [PATCH] logo: move declarations of logos to linux_logo.h
On Thu, 13 Dec 2007, Marcin Slusarz wrote:
> On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote:
> > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz <marcin.slusarz@gmail.com> wrote:
> >
> > > logo: move declarations of logos to linux_logo.h
> > >
> > > there was a mismatch between externs in logo.c and code generated by pnmtologo
> > > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
> >
> > This patch (after I fixed it) keeps on causing trouble: mismatches between
> > the header file declarations and the actual definitions of the lookup
> > tables. This happens as I apply and unapply the patch.
> >
> > It _shouldn't_ happen, but there would appear to be some missing makefile
> > rules. I guess the C files aren't being regenerated when
> > scripts/pnmtologo.c has been altered, so the C files aren't matching the
> > header which this patch alters.
>
> Ok, updated patch below:
>
> logo: move declarations of logos to linux_logo.h
>
> there was a mismatch between externs in logo.c and code generated by pnmtologo

This may cause section conflicts, cfr.
http://lkml.org/lkml/2007/10/24/65

Gr{oetje,eeting}s,
Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
\
 
 \ /
  Last update: 2007-12-14 21:51    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site