Messages in this thread |  | | | Date | Thu, 13 Dec 2007 22:34:24 -0800 | | From | Greg KH <> | | Subject | Re: [RFC PATCH 08/12] PAT 64b: coherent mmap and sysfs bin ioctl | |
On Thu, Dec 13, 2007 at 04:35:05PM -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>> Date: Thu, 13 Dec 2007 16:19:32 -0800> > > On Thu, Dec 13, 2007 at 03:55:51PM -0800, venkatesh.pallipadi@intel.com wrote:
> > > Forward port of coherent-mmap.patch and sysfs-bin-ioctl.patch to x86 tree.
> > > > > > TBD: Do we need the ioctl interface to sysfs or get the type attribute
> > > through a different sysfs file. And then actually specify the attribute
> > > while doing pci_mmap_page_range ;-)> > > > Woah! No, no ioctls on sysfs files, sorry. Not going to happen, do
> > this on a /dev file if you want to have ioctls...> > Well since we told people to move over to sysfs for PCI
> accesses, and that's where mmap() is done via too,> it should be no surprise that we run into problems when
> people want to set attributes for the mmap() as was done
> for the procfs case.> > So you have two choices:> > 1) Balk on the sysfs pci usage, and erase years of effort
> of moving people over to sysfs. Tell them to go back to
> procfs so we can add the attribute setting via ioctl()
> which is absolutely needed.
Ok, sorry, it wasn't blindingly obvious that this was for pci sysfs
devices that are mmaped, that makes a bit more sense.
But I'd like to see what ioctl is wanted here first.
thanks,
greg k-h
|  |