lkml.org 
[lkml]   [2007]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)
    From
    Date

    On Fri, 2007-10-26 at 12:37 -0400, Trond Myklebust wrote:
    > On Fri, 2007-10-26 at 16:48 +0200, Peter Zijlstra wrote:
    >
    > > Miklos, Trond: could you suggest a better fmt for the bdi_init_fmt() for your
    > > respective filesystems?
    > <snip>
    > > Index: linux-2.6-2/fs/nfs/client.c
    > > ===================================================================
    > > --- linux-2.6-2.orig/fs/nfs/client.c
    > > +++ linux-2.6-2/fs/nfs/client.c
    > > @@ -678,7 +678,7 @@ static int nfs_probe_fsinfo(struct nfs_s
    > > goto out_error;
    > >
    > > nfs_server_set_fsinfo(server, &fsinfo);
    > > - error = bdi_init(&server->backing_dev_info);
    > > + error = bdi_init_fmt(&server->backing_dev_info, "nfs-%s-%p", clp->cl_hostname, server);
    >
    > In our debugging printks, we usually use the superblock->s_id, but that
    > only gets initialised later.
    >
    > I'd suggest passing the 'dev_name' from *_get_sb() into
    > *_create_server().

    I just realised that such a name would contain '/' and I'm quite sure
    that makes filesystems unhappy.

    Neil suggested using device numbers which would work, however I think
    those might not be human friendly. While its easy to find the device
    number of a given path (eg.: stat -c %d /), its rather hard to find the
    path belonging to a given device number.





    \
     
     \ /
      Last update: 2007-12-14 15:53    [W:2.949 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site