lkml.org 
[lkml]   [2007]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix page_alloc for larger I/O segments
On Thu, Dec 13, 2007 at 05:03:08PM -0800, Andrew Morton wrote:
> + /*
> + * Find a page of the appropriate migrate type. Doing a
> + * reverse-order search here helps us to hand out pages in
> + * ascending physical-address order.
> + */
> + list_for_each_entry_reverse(page, &pcp->list, lru)

It's not obvious why ascending physical order is a good thing. How
about:

+ /*
+ * Find a page of the appropriate migrate type. Doing a
+ * reverse-order search here helps us to hand out pages in
+ * ascending physical-address order, which improves our
+ * chances of coalescing scatter-gather pages.
+ */
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."


\
 
 \ /
  Last update: 2007-12-14 05:03    [W:0.142 / U:0.056 seconds]
©2003-2011 Jasper Spaans. Advertise on this site