Messages in this thread |  | | | Date | Thu, 13 Dec 2007 21:00:57 -0700 | | From | Matthew Wilcox <> | | Subject | Re: [PATCH] fix page_alloc for larger I/O segments |
| |
On Thu, Dec 13, 2007 at 05:03:08PM -0800, Andrew Morton wrote: > + /* > + * Find a page of the appropriate migrate type. Doing a > + * reverse-order search here helps us to hand out pages in > + * ascending physical-address order. > + */ > + list_for_each_entry_reverse(page, &pcp->list, lru)
It's not obvious why ascending physical order is a good thing. How about:
+ /* + * Find a page of the appropriate migrate type. Doing a + * reverse-order search here helps us to hand out pages in + * ascending physical-address order, which improves our + * chances of coalescing scatter-gather pages. + */ -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
|  |