lkml.org 
[lkml]   [2007]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] fix page_alloc for larger I/O segments (improved)
    From
    Date

    On Thu, 2007-12-13 at 19:46 -0500, Mark Lord wrote:
    > "Improved version", more similar to the 2.6.23 code:
    >
    > Fix page allocator to give better chance of larger contiguous segments (again).
    >
    > Signed-off-by: Mark Lord <mlord@pobox.com
    > ---
    >
    > --- old/mm/page_alloc.c 2007-12-13 19:25:15.000000000 -0500
    > +++ linux-2.6/mm/page_alloc.c 2007-12-13 19:43:07.000000000 -0500
    > @@ -760,7 +760,7 @@
    > struct page *page = __rmqueue(zone, order, migratetype);
    > if (unlikely(page == NULL))
    > break;
    > - list_add(&page->lru, list);
    > + list_add_tail(&page->lru, list);

    Could we put a big comment above this explaining to the would be vm
    tweakers why this has to be a list_add_tail, so we don't end up back in
    this position after another two years?

    James




    \
     
     \ /
      Last update: 2007-12-14 02:01    [W:0.022 / U:1.416 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site