lkml.org 
[lkml]   [2007]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?
    Mark Lord wrote:
    > Andrew Morton wrote:
    >> On Thu, 13 Dec 2007 19:30:00 -0500
    >> Mark Lord <liml@rtr.ca> wrote:
    >>
    >>> Here's the commit that causes the regression:
    >>>
    >>> ...
    >>>
    >>> --- a/mm/page_alloc.c
    >>> +++ b/mm/page_alloc.c
    >>> @@ -760,7 +760,8 @@ static int rmqueue_bulk(struct zone *zone,
    >>> unsigned int order,
    >>> struct page *page = __rmqueue(zone, order, migratetype);
    >>> if (unlikely(page == NULL))
    >>> break;
    >>> - list_add_tail(&page->lru, list);
    >>> + list_add(&page->lru, list);
    >>
    >> well that looks fishy.
    > ..
    >
    > Yeah. I missed that, and instead just posted a patch
    > to search the list in reverse order, which seems to work for me.
    >
    > I'll try just reversing that line above here now.. gimme 5 minutes or so.
    ..

    Yep, that works too. Alternative "improved" patch now posted.


    \
     
     \ /
      Last update: 2007-12-14 01:51    [W:0.055 / U:91.688 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site