Messages in this thread |  | | | Date | Thu, 13 Dec 2007 23:58:59 +0100 | | From | Jarek Poplawski <> | | Subject | Re: [RFC] net: napi fix |
| |
David Miller wrote, On 12/13/2007 11:34 PM:
> From: Jarek Poplawski <jarkao2@gmail.com> > Date: Thu, 13 Dec 2007 23:28:41 +0100 > >> ...I'm afraid I can't understand: I mean doing the same but without >> passing this info with 'work == weight': if driver sends this info, >> why it can't instead call something like napi_continue() with >> this list_move_tail() (and probably additional local_irq_disable()/ >> enble() - but since it's unlikely()?) which looks much more readable, >> and saves one whole unlikely if ()? > > Because the poll list is private to net_rx_action() and we don't > want to expose implementation details like that to every > ->poll() implementation.
So, it seems 'we' failed e.g. exposing napi_complete()... OK, no offense, I'll only mention at the end that there is always a possibility to redefine such a function to {} with any change of implementation. Jarek P.
|  |