Messages in this thread | | | Date | Thu, 13 Dec 2007 16:18:58 -0500 | From | Jeff Layton <> | Subject | Re: [PATCH 2/6] SUNRPC: Break up __svc_create_thread and make svc_create_kthread |
| |
On Thu, 13 Dec 2007 21:06:44 +0000 Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Dec 13, 2007 at 03:40:24PM -0500, Jeff Layton wrote: > > Move the initialization that happens prior to thread creation to a > > new function (svc_prepare_thread) so that we can call it from a new > > thread creation routine. Add a new function svc_create_kthread that > > spawns svc threads using kthread API. > > > > We should be able to eventually convert all of the callers to the > > kthread API, at which point we can drop __svc_create_thread. > > > +static struct svc_rqst * > > +svc_prepare_thread(svc_thread_fn func, struct svc_serv *serv, > > + struct svc_pool *pool) > > Could you just export this helper? I'd rather have callers have full > control over how they create their threads and call into a helper to > initialize the sunrpc state. >
Sure, sounds reasonable. Once I collect comments on this patch and do a respin, I'll plan to export that symbol.
Thanks, -- Jeff Layton <jlayton@redhat.com>
| |