lkml.org 
[lkml]   [2007]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RT] Revert Softdisable for simple irqs.
On Wed, Dec 12, 2007 at 02:40:09PM -0500, Steven Rostedt wrote:
>
> In commit 76d2160147f43f982dfe881404cfde9fd0a9da21 lazy irq disabling
> was implemented, and the simple irq handler had a masking set to it.
>
> Remy Bohmer discovered that some devices in the ARM architecture
> would trigger the mask, but never unmask it. His patch to do the
> unmasking was questioned by Russell King about masking simple irqs
> to begin with. Looking further, it was discovered that the problems
> Remy was seeing was due to improper use of the simple handler by
> devices, and he later submitted patches to fix those. But the issue
> that was uncovered was that the simple handler should never mask.
>
> This patch reverts the masking in the simple handler.
>
> [Note: This version is for the RT patch, and the IRQ_PENDING is needed
> for threaded IRQs]
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

Thanks for submitting this.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:


\
 
 \ /
  Last update: 2007-12-12 20:49    [W:0.798 / U:0.300 seconds]
©2003-2011 Jasper Spaans. Advertise on this site