This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Fri Apr 26 10:05:35 2024 Delivery-date: Wed, 12 Dec 2007 02:20:03 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752507AbXLLCTg (ORCPT ); Tue, 11 Dec 2007 21:19:36 -0500 Received: from pat.uio.no ([129.240.10.15]:44652 "EHLO pat.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077AbXLLCTe (ORCPT ); Tue, 11 Dec 2007 21:19:34 -0500 Received: from mail-mx6.uio.no ([129.240.10.47]) by pat.uio.no with esmtp (Exim 4.67) (envelope-from ) id 1J2HBh-0007tF-Ga; Wed, 12 Dec 2007 03:19:05 +0100 Received: from smtp.uio.no ([129.240.10.9] helo=mail-mx6.uio.no) by mail-mx6.uio.no with esmtp (Exim 4.67) (envelope-from ) id 1J2HBg-0002UT-V3; Wed, 12 Dec 2007 03:19:05 +0100 Received: from c-69-242-210-120.hsd1.mi.comcast.net ([69.242.210.120] helo=[192.168.0.101]) by mail-mx6.uio.no with esmtpsa (SSLv3:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1J2HBg-0002UE-9n; Wed, 12 Dec 2007 03:19:04 +0100 Subject: Re: 2.6.24-rc3-git4 NFS crossmnt regression [SOLVED] From: Trond Myklebust To: Andrew Morton Cc: Maxim Levitsky , bfields@fieldses.org, neilb@suse.de, rjw@sisk.pl, gnome42@gmail.com, linux-kernel@vger.kernel.org, ebiederm@xmission.com, den@openvz.org, linux-nfs@vger.kernel.org In-Reply-To: <20071211181559.fe21687a.akpm@linux-foundation.org> References: <200712101705.30428.maximlevitsky@gmail.com> <20071210130305.d8983fdc.akpm@linux-foundation.org> <200712120401.57128.maximlevitsky@gmail.com> <20071211181559.fe21687a.akpm@linux-foundation Content-Type: multipart/mixed; boundary="=-TlI4Fg2n/Pv+WrlBB4oh" Date: Tue, 11 Dec 2007 21:19:00 -0500 Message-Id: <1197425940.27061.1.camel@heimdal.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 X-UiO-Resend: resent X-UiO-ClamAV-Virus: No X-UiO-Spam-info: not spam, SpamAssassin (score=-0.3, required=5.0, autolearn=disabled, AWL=-0.321) X-UiO-Scanned: 63ADA5A7268ACA2967A0B3C1463A75CECE02A38E X-UiO-SPAM-Test: remote_host: 129.240.10.9 spam_score: -2 maxlevel 200 minaction 2 bait 0 mail/h: 54 total 5695554 max/h 8345 blacklist 0 greylist 0 ratelimit 0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org --=-TlI4Fg2n/Pv+WrlBB4oh Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, 2007-12-11 at 18:15 -0800, Andrew Morton wrote: > > 1) Stale handles - Trond's patch fixes it, but I somehow missed it. > > What is "Trond's patch" and where is it now? He means the one this whole thread started with. See attachment... Trond --=-TlI4Fg2n/Pv+WrlBB4oh Content-Disposition: inline Content-Description: Attached message - Re: 2.6.24-rc3-git4 NFS crossmnt regression Content-Type: message/rfc822 Subject: Re: 2.6.24-rc3-git4 NFS crossmnt regression From: Trond Myklebust To: Shane Cc: Andrew Morton , linux-kernel@vger.kernel.org, "J. Bruce Fields" , "Rafael J. Wysocki" In-Reply-To: References: <20071207040219.e231cbc7.akpm@linux-foundation.org> Content-Type: multipart/mixed; boundary="=-IBupBxkFjx7YOD4mPYpk" Message-Id: <1197053179.7532.23.camel@heimdal.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Date: Fri, 07 Dec 2007 13:46:22 -0500 X-Evolution-Format: text/plain X-Evolution-Account: 1149135252.7829.2@lade.trondhjem.org X-Evolution-Transport: smtp://trondmy;auth=PLAIN@smtp.uio.no/;use_ssl=always X-Evolution-Fcc: imap://trondmy@imap.uio.no/INBOX/Sent X-Evolution-Source: imap://trondmy@imap.uio.no/ --=-IBupBxkFjx7YOD4mPYpk Content-Type: text/plain Content-Transfer-Encoding: 7bit On Fri, 2007-12-07 at 13:14 -0500, Shane wrote: > On Dec 7, 2007 7:02 AM, Andrew Morton wrote: > ... > > > 2.6.24-rc3-git1 is last known good kernel. The problem also exists > > > with the latest snap 2.6.24-rc4-git4. NFS server is 2.6.23-rc9 and > > > is unchanged. > > > > hm, there have been no nfs changes since 2.6.24-rc4. > > Ok, but the problem seems to have appeared before 2.6.24-rc4. > > > > It is easily reproducible here, hopefully for the person who > > > knows how to debug it too :) > > > > > > > I guess a full set of the commands which you typed to reproduce this would > > help. > > Server is 2.6.23-rc9 and is exporting: > > /dirA/dirB > 10.10.20.0/255.255.255.0(rw,async,no_root_squash,no_subtree_check,insecure,crossmnt) > /dirA/dirB/dirC > 10.10.20.0/255.255.255.0(rw,async,no_root_squash,no_subtree_check,insecure) > /dirA/dirB/dirD > 10.10.20.0/255.255.255.0(rw,async,no_root_squash,no_subtree_check,insecure) > > The NFS client (Core2 SMP) 2.6.24-rc3-git4: > > NFS-server:/dirA/dirB /dirA/dirB nfs > auto,rsize=16384,wsize=16384,hard,intr,users,exec,nfsvers=3,tcp,nolock,actimeo=0 > > Then on the client when the new kernel has booted: > > ls /dirA/dirB --> normal listing > ls /dirA/dirB/dirC --> Stale NFS file handle > ls /dirA/dirB/dirD --> Stale NFS file handle > > I will do a few more builds/boots and check -rc3-git2 and -rc3-git3. This problem has already been reported. The fix (which I'm planning on sending to Linus soon) is appended. Cheers Trond --=-IBupBxkFjx7YOD4mPYpk Content-Disposition: inline; filename=linux-2.6.24-001-fix_submounts.dif Content-Type: message/rfc822; name=linux-2.6.24-001-fix_submounts.dif From: Trond Myklebust Date: Subject: NFS: Fix NFS mountpoint crossing... Message-Id: <1197053179.7532.24.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit The check that was added to nfs_xdev_get_sb() to work around broken servers, works fine for NFSv2, but causes mountpoint crossing on NFSv3 to always return ESTALE. Signed-off-by: Trond Myklebust --- fs/nfs/super.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 2426e71..ea92920 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -1475,7 +1475,7 @@ static int nfs_xdev_get_sb(struct file_system_type *fs_type, int flags, error = PTR_ERR(mntroot); goto error_splat_super; } - if (mntroot->d_inode->i_op != &nfs_dir_inode_operations) { + if (mntroot->d_inode->i_op != server->nfs_client->rpc_ops->dir_inode_ops) { dput(mntroot); error = -ESTALE; goto error_splat_super; --=-IBupBxkFjx7YOD4mPYpk-- --=-TlI4Fg2n/Pv+WrlBB4oh-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/