[lkml]   [2007]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: 2.6.24-rc4-mm1
    Kok, Auke wrote:
    > Andrew Morton wrote:
    >> On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <> wrote:
    >>>> - Lots of device IDs have been removed from the e1000 driver and moved
    >>>> over
    >>>> to e1000e. So if your e1000 stops working, you forgot to set
    >>>> CONFIG_E1000E.
    >>> Wouldn't it make sense to just default this to on if E1000 was on, rather
    >>> than screwing
    >>> everybody for no good reason (plus breaking all the automated testing, etc
    >>> etc)?
    >>> Much though I love random refactoring, it is fairly painful to just keep
    >>> changing the
    >>> names of things.
    >> (cc netdev and Auke)
    >> Yes, that would be very sensible. CONFIG_E1000E should default to whatever
    >> CONFIG_E1000 was set to.
    > which is "y" for x86 and friends, ppc, arm and ia64 through 'defconfig'. the
    > Kconfig files do not have defaults in them.
    > I can send a patch to adjust the defconfig files, would that be OK? I certainly
    > think that would be reasonable, I dislike setting defaults through defconfig for
    > network drivers myself and rather would not do that.

    that should read "dislike setting defaults through Kconfig ..."


     \ /
      Last update: 2007-12-11 23:05    [W:2.304 / U:26.852 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site