[lkml]   [2007]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC] [PATCH] A clean aEvgeniy pproach to writeout throttling
On Monday 10 December 2007 04:16, Jens Axboe wrote:
> OK, let me get the neon out then. This has nothing to do with
> throttling, I thought I made it clear that I get why you store the
> origin queue in ->bi_queue. I'm concerned with the workings of
> redirecting a bio. Previously we looked up the queue associated with
> bio->bi_bdev inside the loop in __generic_make_request(), as is
> REQUIRED to correctly locate a DIFFERENT queue if bio->bi_bdev has
> been changed to point somewhere else.

Rhetoric aside, again.

We are only interested in throttling against the bio->bi_bdev that was
stored in the bio at the time of the call to generic_make_request, why
should we care about the redirected value?



 \ /
  Last update: 2007-12-10 13:31    [W:0.057 / U:0.532 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site