lkml.org 
[lkml]   [2007]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] [PATCH] A clean approach to writeout throttling
From
Date
Hey, Daniel,

I'm just getting around to looking at this. One thing jumped out at me:

> + if (bio->bi_throttle) {
> + struct request_queue *q = bio->bi_queue;
> + bio->bi_throttle = 0; /* or detect multiple endio and err? */
> + atomic_add(bio->bi_throttle, &q->available);
> + wake_up(&q->throttle_wait);
> + }

I'm feeling like I must be really dumb, but...how can that possibly
work? You're zeroing >bi_throttle before adding it back into
q->available, so the latter will never increase...

jon


\
 
 \ /
  Last update: 2007-12-10 22:35    [W:0.086 / U:37.920 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site