Messages in this thread | | | Date | Mon, 10 Dec 2007 19:50:08 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like |
| |
On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: > > This way gcc can warn for wrong format strings
This loks good. Can I get i s-o-b then I will apply it.
Sam
> > --- > scripts/mod/modpost.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > Index: linux/scripts/mod/modpost.c > =================================================================== > --- linux.orig/scripts/mod/modpost.c > +++ linux/scripts/mod/modpost.c > @@ -33,7 +33,9 @@ enum export { > export_unused_gpl, export_gpl_future, export_unknown > }; > > -void fatal(const char *fmt, ...) > +#define PRINTF __attribute__ ((format (printf, 1, 2))) > + > +PRINTF void fatal(const char *fmt, ...) > { > va_list arglist; > > @@ -46,7 +48,7 @@ void fatal(const char *fmt, ...) > exit(1); > } > > -void warn(const char *fmt, ...) > +PRINTF void warn(const char *fmt, ...) > { > va_list arglist; > > @@ -57,7 +59,7 @@ void warn(const char *fmt, ...) > va_end(arglist); > } > > -void merror(const char *fmt, ...) > +PRINTF void merror(const char *fmt, ...) > { > va_list arglist; >
| |