lkml.org 
[lkml]   [2007]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Correct types for mod_devicetable.h (was: Re: m68k build failure)
On Sun, Dec 09, 2007 at 06:08:18PM +0100, Pierre Ossman wrote:
> On Sun, 2 Dec 2007 12:22:31 +0100 (CET)
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> >
> > I gave it a try:
> > - Remove existing alignment attributes from some device_id types
> > - Introduce kernel_* types with proper size and alignment for
> > cross-compilation (sample <asm/kerneltypes.h> for m68k included)
> > - Introduce BITS_PER_KERNEL_LONG, to make it clearer it applies to the target
> >
> > Apart from a cross-compile session for m68k, it's untested.
> >
>
> This still requires a bit of maintenance to set up a kerneltypes.h for every arch.

Better doing this work once than fixing similar issues again and again.

> It also means we have to be very careful that gcc's internal alignment settings matched the ones in our header.

There's nothing "gcc internal" about struct alignment - remember that
any change in struct alignment would change our userspace ABI.

> Rgds
> Pierre

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2007-12-10 19:13    [W:1.191 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site